[{2} files left] message is wrong when connection breaks

Enhanced frontend add-on to queue files.
Post Reply
Bogdan
Posts: 12
Joined: Wed Oct 14, 2009 10:56 pm

[{2} files left] message is wrong when connection breaks

Post by Bogdan »

Number of files left keep decreasing with every upload retry, even files are not being uploaded.

Steps to reproduce:
1) This is harder to reproduce when a file is split. So turn off chuncking of set chunksize larger than the file size
2) Drop N > 1 files into jBatchUpload
3) Start sending
4) Pull the network cable (or disable the network connection)
5) See the status message, every [retryinterval], number of "files left" keeps decreasing!

--Reason--
in "\src\jfileupload\transfer\client\mdesign\ProgressPanel.java", variable [remaining] is decreased on transferStarted()

--Fix--
Move line:
if ((amount > 0) && (remaining > 0) && (fchunkid == 1)) remaining--;
to transferCompleted()

--Note--
This actually helps with other annoyance, because now number of "files left", is really of those left to upload, not MINUS ONE like it used to!
Attachments
src.zip
(6.92 KiB) Downloaded 916 times

User avatar
support
Posts: 1503
Joined: Sun Jan 27, 2008 6:19 pm

Re: [{2} files left] message is wrong when connection breaks

Post by support »

Thanks for the report.

Post Reply